-
Notifications
You must be signed in to change notification settings - Fork 564
blockstoragev3: support extra_spec for volumetypes #2123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
205af79
to
a553e9a
Compare
a553e9a
to
6feb2c1
Compare
Build failed.
|
recheck |
Build succeeded.
|
jtopjian
reviewed
Mar 7, 2021
6feb2c1
to
f8eb3f6
Compare
Build failed.
|
f8eb3f6
to
9757c9a
Compare
Add support for blockstoragev3 volumetype extra_spec operations such as: - create extra specs for volume type - list all extra specs of volume type - get specific extra spec of volume type - update specific extra spec of volume type - delete specific extra spec of volume type
9757c9a
to
fb1cbde
Compare
Build succeeded.
|
@nikParasyr This looks good to me. Are you finished working on this? |
@jtopjian yes, this can be merged from my side |
jtopjian
approved these changes
Mar 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for blockstoragev3 volumetype extra_spec operations
such as:
For #649
Links to the line numbers/files in the OpenStack source code that support the
code in this PR:
CreateExtraSpecs:
ListExtraSpecs:
GetExtraSpec:
UpdateExtraSpec:
DeleteExtraSpec: