Skip to content

[v2] [neutron]: introduce Stateful argument for the security groups #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2024
Merged

[v2] [neutron]: introduce Stateful argument for the security groups #3119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/acceptance/openstack/networking/v2/extensions/security_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ func TestSecurityGroupsCreateUpdateDelete(t *testing.T) {
group, err := CreateSecurityGroup(t, client)
th.AssertNoErr(t, err)
defer DeleteSecurityGroup(t, client, group.ID)
th.AssertEquals(t, group.Stateful, true)

rule, err := CreateSecurityGroupRule(t, client, group.ID)
th.AssertNoErr(t, err)
Expand All @@ -32,6 +33,7 @@ func TestSecurityGroupsCreateUpdateDelete(t *testing.T) {
updateOpts := groups.UpdateOpts{
Name: name,
Description: &description,
Stateful: new(bool),
}

newGroup, err := groups.Update(context.TODO(), client, group.ID, updateOpts).Extract()
Expand All @@ -40,6 +42,7 @@ func TestSecurityGroupsCreateUpdateDelete(t *testing.T) {
tools.PrintResource(t, newGroup)
th.AssertEquals(t, newGroup.Name, name)
th.AssertEquals(t, newGroup.Description, description)
th.AssertEquals(t, newGroup.Stateful, false)

listOpts := groups.ListOpts{}
allPages, err := groups.List(client, listOpts).AllPages(context.TODO())
Expand Down
7 changes: 7 additions & 0 deletions openstack/networking/v2/extensions/security/groups/requests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ type ListOpts struct {
ID string `q:"id"`
Name string `q:"name"`
Description string `q:"description"`
Stateful *bool `q:"stateful"`
TenantID string `q:"tenant_id"`
ProjectID string `q:"project_id"`
Limit int `q:"limit"`
Expand Down Expand Up @@ -63,6 +64,9 @@ type CreateOpts struct {

// Describes the security group.
Description string `json:"description,omitempty"`

// Stateful indicates if the security group is stateful or stateless.
Stateful *bool `json:"stateful,omitempty"`
}

// ToSecGroupCreateMap builds a request body from CreateOpts.
Expand Down Expand Up @@ -97,6 +101,9 @@ type UpdateOpts struct {

// Describes the security group.
Description *string `json:"description,omitempty"`

// Stateful indicates if the security group is stateful or stateless.
Stateful *bool `json:"stateful,omitempty"`
}

// ToSecGroupUpdateMap builds a request body from UpdateOpts.
Expand Down
3 changes: 3 additions & 0 deletions openstack/networking/v2/extensions/security/groups/results.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ type SecGroup struct {
// traffic entering and leaving the group.
Rules []rules.SecGroupRule `json:"security_group_rules"`

// Indicates if the security group is stateful or stateless.
Stateful bool `json:"stateful"`

// TenantID is the project owner of the security group.
TenantID string `json:"tenant_id"`

Expand Down