[v2] Improve support for network standard-attr-* extensions
#3328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistently add support for the neutron `Resource revision numbers` extension [1] for more resources that support it. It adds a `RevisionNumber` field to all responses, and allows filtering via the `RevisionNumber` list option. It was only partially implemented. Also support the `If-Match` constraints, and add test for it. [1] https://docs.openstack.org/api-ref/network/v2/#revisions
Add a few missing `CreatedAt` and `UpdatedAt` fields for networking resources.
Due to https://bugs.launchpad.net/neutron/+bug/2101871, which causes neutron to return a 500 error.
Since 5819dc0, `getReleaseFromEnv()` trims the `stable/` prefix, which caused the condition in `SkipRelease()` to fail if we looked for a release name including the prefix. Fix `SkipRelease()` to account for release names with a `stable/` prefix.
|
man, this |
EmilienM
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #3318 and #3326
Consistently add support for the neutron
Resource revision numbersextension [1] for more resources that support it. It adds
a
RevisionNumberfield to all responses, and allows filtering via theRevisionNumberlist option. It was only partially implemented.Support the
If-Matchconstraints for these resources, and add test for it.Add a few missing
CreatedAtandUpdatedAtfields for networkingresources.
[1] https://docs.openstack.org/api-ref/network/v2/#revisions