Skip to content

dns: add support for /v2/quotas #3414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

dns: add support for /v2/quotas #3414

merged 1 commit into from
Jun 25, 2025

Conversation

kayrus
Copy link
Contributor

@kayrus kayrus commented Jun 5, 2025

This is a rebase of #2399 and #3186

Closes #2398

@github-actions github-actions bot added edit:dns This PR updates dns code semver:minor Backwards-compatible change backport-v2 This PR will be backported to v2 labels Jun 5, 2025
@coveralls
Copy link

coveralls commented Jun 5, 2025 •
edited
Loading

Coverage Status

coverage: 63.723% (+0.02%) from 63.704%
when pulling b8eb8c0 on kayrus:dns_quotas
into 992e8b7 on gophercloud:main.

@kayrus kayrus force-pushed the dns_quotas branch 2 times, most recently from ab9616c to 04cf9a0 Compare June 6, 2025 06:43
@github-actions github-actions bot added edit:actions This PR updates GitHub Actions code edit:testinfra This PR updates testing infrastructure code labels Jun 6, 2025
@kayrus kayrus force-pushed the dns_quotas branch 3 times, most recently from 83dc803 to 35ce048 Compare June 10, 2025 15:04
@kayrus
Copy link
Contributor Author

kayrus commented Jun 10, 2025

@stephenfin could you please take a look into the acceptance tests results?

 === FAIL: internal/acceptance/openstack/dns/v2 TestQuotaGetUpdate (0.02s)
    quotas_test.go:20: Failure in quotas_test.go, line 20: unexpected error "unversioned endpoint with multiple alternatives not supported"

=== FAIL: internal/acceptance/openstack/dns/v2 TestRecordSetsListByZone (0.02s)
    recordsets_test.go:18: Failure in recordsets_test.go, line 18: unexpected error "unversioned endpoint with multiple alternatives not supported"

=== FAIL: internal/acceptance/openstack/dns/v2 TestRecordSetsCRUD (0.02s)
    recordsets_test.go:57: Failure in recordsets_test.go, line 57: unexpected error "unversioned endpoint with multiple alternatives not supported"

=== FAIL: internal/acceptance/openstack/dns/v2 TestShareCRD (0.14s)
    identity.go:27: Attempting to create project: ACPTTESTBnIABD6y
    identity.go:44: Successfully created project ACPTTESTBnIABD6y with ID 69c2c820d8f94aa9ae2ad785ff340f19
    shares_test.go:27: Failure in shares_test.go, line 27: unexpected error "unversioned endpoint with multiple alternatives not supported"
    identity.go:240: Deleted project: 69c2c820d8f94aa9ae2ad785ff340f19

=== FAIL: internal/acceptance/openstack/dns/v2 TestTransferRequestCRUD (0.04s)
    transfers_test.go:20: Failure in transfers_test.go, line 20: unexpected error "unversioned endpoint with multiple alternatives not supported"

=== FAIL: internal/acceptance/openstack/dns/v2 TestTransferRequestAccept (0.14s)
    identity.go:27: Attempting to create project: ACPTTESTM8pwDwbw
    identity.go:44: Successfully created project ACPTTESTM8pwDwbw with ID c33beb335a86402b95f3e4f357afd8c0
    transfers_test.go:69: Failure in transfers_test.go, line 69: unexpected error "unversioned endpoint with multiple alternatives not supported"
    identity.go:240: Deleted project: c33beb335a86402b95f3e4f357afd8c0

=== FAIL: internal/acceptance/openstack/dns/v2 TestZonesCRUD (0.06s)
    zones_test.go:17: Failure in zones_test.go, line 17: unexpected error "unversioned endpoint with multiple alternatives not supported"

@kayrus kayrus mentioned this pull request Jun 11, 2025
Merged
mandre
mandre reviewed Jun 17, 2025
View reviewed changes
Copy link
Contributor

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of nits. Let's also re-run the acceptance tests once #3420 is in.

openstack/dns/v2/quotas/requests.go Outdated
type ListOpts struct {
}

// ToZoneListQuery formats a ListOpts into a query string.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment is off.

openstack/dns/v2/quotas/requests.go Outdated
return q.String(), err
}

// Get returns information about the quota, given its ID.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can clarify a bit

Suggested change
// Get returns information about the quota, given its ID.
// Get returns information about the quota for a given project ID.

@SuperSandro2000 @pierreprinetti @kayrus
dns: add support for /v2/quotas
b8eb8c0 
Co-Authored-By: Pierre Prinetti <pierreprinetti@redhat.com>
@kayrus kayrus requested a review from mandre June 25, 2025 07:16
stephenfin
stephenfin approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@stephenfin stephenfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I'll hold off merging to give @mandre time to come back around to this.

@mandre mandre merged commit c7eaf6f into gophercloud:main Jun 25, 2025
18 checks passed
@gophercloud-backport-bot gophercloud-backport-bot bot mentioned this pull request Jun 25, 2025
Merged
@kayrus kayrus deleted the dns_quotas branch June 25, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandre mandre mandre approved these changes

@stephenfin stephenfin stephenfin approved these changes

Assignees
No one assigned
Labels
backport-v2 This PR will be backported to v2 edit:actions This PR updates GitHub Actions code edit:dns This PR updates dns code edit:testinfra This PR updates testing infrastructure code semver:minor Backwards-compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for dns/v2/quotas
5 participants
@kayrus @coveralls @mandre @stephenfin @SuperSandro2000