Add ProviderClient.DeepCopy, ServiceClient.DeepCopy #3485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
|
CC @kayrus |
|
I have a gut feeling that this is not so easy. Especially with function pointers. I also assume that there should be mutexes. |
|
Yeah, I need to play around with it more. I am creating new mutexes as part of the copy, but I don't know about the function pointers. Let me mark this as draft while I investigate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephen Finucane stephenfin@redhat.com
Fixes #1987
This is a first pass. I need to better understand what we should be copying and what we shouldn't.