Skip to content

gopherjs test github.com/eaburns/flac fails #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hajimehoshi opened this issue Mar 6, 2016 · 3 comments
Closed

gopherjs test github.com/eaburns/flac fails #417

hajimehoshi opened this issue Mar 6, 2016 · 3 comments

Comments

@hajimehoshi
Copy link
Member 

$ go test github.com/eaburns/flac
ok      github.com/eaburns/flac 0.006s

$ gopherjs test github.com/eaburns/flac
gopherjs: Source maps disabled. Use Node.js 4.x with source-map-support module for nice stack traces.
PASS
fatal error: all goroutines are asleep - deadlock!
FAIL    github.com/eaburns/flac 0.338s

IIUC that flac package and its dependencies are in pure Go so the test should be passed in theory.
@dmitshur
Copy link
Member

dmitshur commented Mar 6, 2016

Cannot reproduce with latest version of GopherJS and that package.

$ go get -u github.com/eaburns/flac
$ go test github.com/eaburns/flac
ok      github.com/eaburns/flac 0.023s
$ gopherjs test github.com/eaburns/flac
gopherjs: Source maps disabled. Use Node.js 4.x with source-map-support module for nice stack traces.
PASS
ok      github.com/eaburns/flac 0.548s
$

Can you try updating GopherJS to latest version (go get -u github.com/gopherjs/gopherjs), updating that package to latest version (go get -u github.com/eaburns/flac) and redoing the test?

There have been some bug fixes with goroutine deadlock detection in GopherJS in the recent past.

@hajimehoshi
Copy link
Member Author

Yeah, I've updated GopherJS but the still deadlock happens.

@hajimehoshi
Copy link
Member Author

Ah, it's succeeded after installing node-gyp. This is still mysterious but it'd not be a practical problem. Thanks.

@Lekensteyn Lekensteyn mentioned this issue Oct 12, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hajimehoshi @dmitshur