Skip to content

godep is asking to install 'vendored' #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dfuentes77 opened this issue Mar 17, 2016 · 5 comments
Closed

godep is asking to install 'vendored' #423

dfuentes77 opened this issue Mar 17, 2016 · 5 comments

Comments

@dfuentes77
Copy link

I'm brand new to go. When I try to run godep save, I've run into this error which I found the reference to "vendored" comes from your package. I'd appreciate any help on how to handle this with godep. Thanks in advance.

$ godep save ./...
godep: Package (vendored) not found

@dmitshur
Copy link
Member

I'm brand new to go. When I try to run godep save

Could you provide more details about what you're trying to do and achieve?

@dfuentes77
Copy link
Author

I basically ran godep save ./... inside of a go env that uses the gopherjs package. It outputted this:

godep: Package (github.com/gopherjs/gopherjs/js) not found

I then installed that package w/

go get github.com/gopherjs/gopherjs/js

I then ran godep save ./... again and received this:

godep: Package (vendored) not found

I then grepped for 'vendored' to find out who is using it

$ grep -ri vendored *
...
src/github.com/gopherjs/gopherjs/tests/misc_test.go: "vendored" src/github.com/gopherjs/gopherjs/tests/misc_test.go: if vendored.Answer != 42 { src/github.com/gopherjs/gopherjs/tests/vendor/vendored/vendored.go:package vendored
...

I actually just tested a quick fix where I edited github.com/gopherjs/gopherjs/tests/misc_test.go locally and change "vendored" in the import section to:

"github.com/gopherjs/gopherjs/tests/vendor/vendored"

it stopped saying not found and continued to the next dependency that was not found, until I installed all those subsequent packges, and it went back to complaining:

godep: Package (vendored) not found

@emidoots
Copy link

Hi @dfuentes77 -- I think the question @shurcooL had was "why do you wish to vendor GopherJS using godep in the first place"?

I'm not sure about Godep, but you might have better luck with govendor -- but I have never used it to vendor GopherJS because it is already so stable. Generally you only vendor packages that are 'external', like user-written packages etc. Vendoring GopherJS is a bit like trying to vendor the standard library net/http package -- it doesn't make very much sense IMO.

@dmitshur
Copy link
Member

If I understand correctly, @dfuentes77, do you have a project that imports github.com/gopherjs/gopherjs, and you're trying to run godep save ./... inside that project. Is that right?

If so, I think this is the same issue as #415. Can you check if that's the case? Richard provided a comment there that you can look at, see #415 (comment).

@dmitshur
Copy link
Member

Closing because no response after many months, so there's nothing actionable left to do here. As far as I can tell, this is a duplicate of #415.

Feel free to comment or reopen if there any updates here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants