Skip to content

doc: explain how to re-build compiler/natives #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
broady opened this issue Sep 16, 2016 · 3 comments
Closed

doc: explain how to re-build compiler/natives #517

broady opened this issue Sep 16, 2016 · 3 comments
Labels
documentation

Comments

@broady
Copy link

broady commented Sep 16, 2016 •
edited
Loading

The instructions are:

Setup:

go get github.com/shurcooL/vfsgen/cmd/vfsgendev github.com/shurcooL/httpfs/...

Regenerate:

go generate github.com/gopherjs/gopherjs/compiler/natives && \
go install github.com/gopherjs/gopherjs && \
rm -rf $(go env GOROOT)/pkg/*_js
@neelance
Copy link
Member

rm -rf $(go env GOROOT)/pkg/*_js should not be necessary. GopherJS should detect the changed timestamps.

@dmitshur
Copy link
Member

Agreed, we should have a document that includes information needed for development of GopherJS. Thanks for reporting this @broady.

The question is where to keep such a document.

It can either be a section in the README... Or perhaps, let's just have a link in README that points to a wiki page. We already have a page for developer guidelines at https://github.com/gopherjs/gopherjs/wiki/Developer-Guidelines, so this can be a similar page, or maybe merge those into one. Having it be a wiki rather than in README should make updating it a little less friction I hope.

@dmitshur
Copy link
Member

dmitshur commented Sep 19, 2016 •
edited
Loading

I've cleaned up that page a bit, and added a section on code generation.

https://github.com/gopherjs/gopherjs/wiki/Developer-Guidelines#code-generation

@broady, how does that look to you?

As a last step to resolve this issue, I'll make a PR to add a "Development" section in the README with a link to that page. Edit: Made #520, please take a look.

dmitshur added a commit that referenced this issue Sep 19, 2016
@dmitshur
README: Add "GopherJS Development" section.
3fea25e 
The linked document covers things like code style, code generation,
and other notes and expectations for this project.

Resolves #517.
@dmitshur dmitshur mentioned this issue Sep 19, 2016
Merged
dmitshur added a commit that referenced this issue Sep 19, 2016
@dmitshur
README: Add "GopherJS Development" section. (#520)
40a48a3 
The linked document covers things like code style, code generation,
and other notes and expectations for this project.

Resolves #517.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@neelance @broady @dmitshur