Skip to content

Investigate why math.TestGamma needs slightly increase tolerances to pass in GopherJS 1.8-1. #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dmitshur opened this issue Feb 17, 2017 · 0 comments
Open

Investigate why math.TestGamma needs slightly increase tolerances to pass in GopherJS 1.8-1. #589

dmitshur opened this issue Feb 17, 2017 · 0 comments
Labels
NeedsInvestigation

Comments

@dmitshur
Copy link
Member

See 5e896be.

The TODO says:

// TODO: Is there a better way to fix TestGamma? It's weird that only one test
//       requires increasing tolerances. Perhaps there's a better fix? Maybe we
//       should override TestGamma specifically and not the package-wide tolerances,
//       because this will cause many other tests to be less accurate. Or maybe this
//       is fine?

@neelance commented:

I'm still wondering where exactly we're losing precision. I guess it is because we're using some JS native math functions which are implemented slightly differently than the Go ones. Investigate?

This issue is to track that investigation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmitshur