Skip to content

gcimporter15 is gone so build fails #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cvermilion opened this issue Apr 10, 2018 · 2 comments
Closed

gcimporter15 is gone so build fails #788

cvermilion opened this issue Apr 10, 2018 · 2 comments

Comments

@cvermilion
Copy link

gopherjs depends on the golang.org/x/tools/go/gcimporter15 package, which has been deprecated for some time:

https://godoc.org/golang.org/x/tools/go/gcimporter15

Deprecated: this package will be deleted in October 2017. New code should use golang.org/x/tools/go/gcexportdata.

The removal was finally done last night, so now go get github.com/gopherjs/gopherjs fails for me with an error like:

go get -d github.com/gopherjs/gopherjs
package golang.org/x/tools/go/gcimporter15: cannot find package "golang.org/x/tools/go/gcimporter15" in any of:
	/usr/local/go/src/golang.org/x/tools/go/gcimporter15 (from $GOROOT)
	/home/circleci/project/src/golang.org/x/tools/go/gcimporter15 (from $GOPATH)
myitcv added a commit to myitcv/gopherjs that referenced this issue Apr 10, 2018
@myitcv
compiler: vendor golang.org/x/tools/go/gcimporter15
172f8c0 
As of 5dfd8930f264888dd5fe26820a0ac605a384dd33
golang.org/x/tools/go/gcimporter15 has been removed (in line with a
promise to remove this old API). This CL vendors a copy of
golang.org/x/tools/go/gcimporter15 as of
14d5b80f954f510ba9bcd241821b6f4828498e1a
(5dfd8930f264888dd5fe26820a0ac605a384dd33~1) minus *_test.go files and
the testdata directory (which contained binary files).

This is effectively a sticking plaster until we migrate, per the
deprecation notice, to golang.org/x/tools/go/gcexportdata.

Fixes gopherjs#788
@myitcv myitcv mentioned this issue Apr 10, 2018
Merged
myitcv added a commit to myitcv/gopherjs that referenced this issue Apr 10, 2018
@myitcv
compiler: vendor golang.org/x/tools/go/gcimporter15
2b066ec 
As of 5dfd8930f264888dd5fe26820a0ac605a384dd33
golang.org/x/tools/go/gcimporter15 has been removed (in line with a
promise to remove this old API). This CL vendors a copy of
golang.org/x/tools/go/gcimporter15 as of
14d5b80f954f510ba9bcd241821b6f4828498e1a
(5dfd8930f264888dd5fe26820a0ac605a384dd33~1) minus *_test.go files and
the testdata directory (which contained binary files).

This is effectively a sticking plaster until we migrate, per the
deprecation notice, to golang.org/x/tools/go/gcexportdata.

Fixes gopherjs#788
@myitcv
Copy link
Member

myitcv commented Apr 10, 2018

Thanks @cvermilion - I've pushed up #789 as a sticking plaster until we migrate, per the
deprecation notice, to golang.org/x/tools/go/gcexportdata

dmitshur pushed a commit that referenced this issue Apr 10, 2018
@myitcv @dmitshur
compiler: Vendor golang.org/x/tools/go/gcimporter15.
558a913 
The golang.org/x/tools/go/gcimporter15 package has been removed (as
promised) in golang/tools@5dfd893.
This change vendors a copy of that package at golang/tools@14d5b80
without *_test.go and testdata (which contained binary files).

The deprecation notice suggests that new code should use
golang.org/x/tools/go/gcexportdata package, which we can
consider in the future.

Fixes #788.

GitHub-Pull-Request: #789.
@dmitshur
Copy link
Member

Thanks for reporting this @cvermilion and sending the PR @myitcv!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cvermilion @dmitshur @myitcv