Skip to content

Bug in externalize, internalize functions #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dave opened this issue May 25, 2018 · 4 comments
Open

Bug in externalize, internalize functions #825

dave opened this issue May 25, 2018 · 4 comments

Comments

@dave
Copy link
Contributor

dave commented May 25, 2018 •
edited
Loading

There's a bug in the externalize and internalize prelude functions. They both access the first struct field before checking if there's no fields (here and here)... here's a simple demo which throws a JS exception Cannot read property 'prop' of undefined:

https://play.jsgo.io/308c189e795b573511cbc4d4606af6b0a60a065a

I've fixed it here: #824

p.s. I don't have node so I didn't run the uglify script... Perhaps someone can do that for me?
@hajimehoshi
Copy link
Member

p.s. I don't have node so I didn't run the uglify script... Perhaps someone can do that for me?

It might be nice if we have a Docker image to execute this?

@flimzy
Copy link
Member

flimzy commented Jul 16, 2018

It might be nice if we have a Docker image to execute this?

You mean as part of the CI pipeline? Or that someone can install and run locally? The latter sounds like more hassle to use than installing the direct requirements.

@hajimehoshi
Copy link
Member

I meant the latter. Is this so hassle? I don't have a strong opinion but in my opinion Docker feels safer than installing npm and their libs. This is just my preference :-)

@flimzy
Copy link
Member

flimzy commented Jul 16, 2018 •
edited
Loading

Well, it's a hassle for anyone who doesn't already have Docker installed. Docker also isn't especially natural for simple input/output operations, although I'm sure that can be worked around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hajimehoshi @dave @flimzy