Update to Go 1.16.3 and add full support for runtime.Callers() #1014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.16.3 added yet another test in the `testing` package, which relied upon these functions, but since most of the support already existed, I decided to complete it instead of skipping yet another test. As a result, I was able to re-enable several tests in `io` and `testing` packages.
flimzy
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.16.3 introduced a new regression test in the
testingpackage, which also requiredruntime.Callers(). Since I've already implemented the hard part of the call stack support, I went ahead and completed it. I think this is the last pull request before we can merge go1.16-stdlib into master (famous last words).Updates #989