Fix syscall build errors on M1 Macs (darwin/arm64)
#1029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So long as we rely on OS-specific syscalls, we must build the package with OS-appropriate GOOS/GOARCH (see also gopherjs#693). Using runtime.GOOS here is not ideal, since it ignores environment variables, making "cross-compiling" impossible. This is not a big deal in most cases, but makes reproducing errors like in gopherjs#1027 more difficult.
This mimics behavior of the build context for the upstream sources and allows us to customize overlays for the darwin/arm64 platform.
They seem to be using different trampoline function names compared to intel architecture.
flimzy
approved these changes
May 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from the fix itself, this PR includes changes to the build system required for the fix to work:
syscalloverlays.syscallpackage.Fixes #1027.