Fix standard library test failures in internal packages.
#1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d72db7 to
8cac780
Compare
flimzy
approved these changes
Sep 17, 2021
8cac780 to
1125e93
Compare
This package seems to be related to the new register-based ABI in Go 1.17, which is completely irrelevant for GopherJS.
The fix is two-fold:
1. `disableSplice` is initialized with `(*bool)(nil)` to work around
gopherjs#1060.
2. Skipped `TestSplicePipePool`, which relies in runtime features
GopherJS doesn't support.
1125e93 to
e835da2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal/abifrom CI, since it's not relevant to GopherJS.internal/pollpipe pool.