Skip to content

Triage remaining gorepo test failures in 1.18 #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 27, 2022
Merged

Triage remaining gorepo test failures in 1.18 #1131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9c7b3f9
Skip 3 gorepo tests that attempt to pass unsupported flags:
nevkontakte Jul 16, 2022
8af68a2
Mark fixedbugs/issue15975.go as passing again.
nevkontakte Jul 16, 2022
6d8aaec
Allow multiple "_" fields in `reflect.StructOf()`.
nevkontakte Jul 16, 2022
62b3001
Update VFS.
nevkontakte Jul 16, 2022
68505dc
Skip fixedbugs/issue48898.go
nevkontakte Jul 17, 2022
d92466f
Skip fixedbugs/issue48536.go, which uses `unsafe.Add()`.
nevkontakte Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions compiler/natives/fs_vfsdata.go
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion compiler/natives/src/reflect/reflect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ func StructOf(fields []StructField) Type {
}
}

if _, dup := fset[name]; dup {
if _, dup := fset[name]; dup && name != "_" {
panic("reflect.StructOf: duplicate field " + name)
}
fset[name] = struct{}{}
Expand Down
8 changes: 7 additions & 1 deletion tests/gorepo/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ var knownFails = map[string]failReason{
"fixedbugs/issue14646.go": {category: unsureIfGopherJSSupportsThisFeature, desc: "tests runtime.Caller behavior in a deferred func in SSA backend... does GopherJS even support runtime.Caller?"},
"fixedbugs/issue15039.go": {desc: "valid bug but deal with after Go 1.7 support is out? it's likely not a regression"},
"fixedbugs/issue15281.go": {desc: "also looks valid but deal with after Go 1.7 support is out? it's likely not a regression"},
"fixedbugs/issue15975.go": {desc: "also looks valid but deal with after Go 1.7 support is out?"},

// These are new tests in Go 1.8.
"fixedbugs/issue17381.go": {category: unsureIfGopherJSSupportsThisFeature, desc: "tests runtime.{Callers,FuncForPC} behavior in a deferred func with garbage on stack... does GopherJS even support runtime.{Callers,FuncForPC}?"},
Expand Down Expand Up @@ -150,6 +149,13 @@ var knownFails = map[string]failReason{

// These are new tests in Go 1.17.8
"fixedbugs/issue50854.go": {category: lowLevelRuntimeDifference, desc: "negative int32 overflow behaves differently in JS"},

// These are new tests in Go 1.18
"fixedbugs/issue46938.go": {category: notApplicable, desc: "tests -d=checkptr compiler mode, which GopherJS doesn't support"},
"fixedbugs/issue47928.go": {category: notApplicable, desc: "//go:nointerface is a part of GOEXPERIMENT=fieldtrack and is not supported by GopherJS"},
"fixedbugs/issue49665.go": {category: other, desc: "attempts to pass -gcflags=-G=3 to enable generics, GopherJS doesn't expect the flag; re-enable in Go 1.19 where the flag is removed"},
"fixedbugs/issue48898.go": {category: other, desc: "https://github.com/gopherjs/gopherjs/issues/1128"},
"fixedbugs/issue48536.go": {category: usesUnsupportedPackage, desc: "https://github.com/gopherjs/gopherjs/issues/1130"},
}

type failCategory uint8
Expand Down