Skip to content

Final cleanups for Go 1.18 #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 1, 2022
Merged

Final cleanups for Go 1.18 #1133

merged 10 commits into from
Aug 1, 2022

Conversation

nevkontakte
Copy link
Member

  • Update tested version to 1.18.4 and address new gorepo test failures.
  • Cleanup overlays that are no longer necessary.
  • Remove Wrapper type from syscall/js like in upstream.
  • Emit explicit errors when encountering typeparams.

Updates #1092.

Even though the compiler was usually able to compile them into
_something_, the code was likely incorrect in all cases. To prevent
users from tripping up on that the compiler will return an error if it
encounters type params until
gopherjs#1013 is resolved.
Go 1.18 upstream includes the fix, which makes the overlay unnecessary.
This mirrors the change in the upstream.
Upstream already skips it for wasm, so it should be ok for us to skip it
as well.
GopherJS doesn't have the problem it targets, but its println() format
is different from upstream Go, which causes the test failure.
@nevkontakte nevkontakte requested a review from flimzy August 1, 2022 15:13
@nevkontakte nevkontakte merged commit 7736106 into gopherjs:go1.18 Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants