Ability to call overridden functions from the std library #1216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, every overriden standard library function was renamed '_'. Now, if there is the following directive in the function comment: "//gopherjs:keep_overridden", they are prefixed with "_gopherjs_overridden_" so that they can be called from the overriding function. This is typically useful to use the standard library implementation as a fallback.
Before this commit, TestOnePassCutoff was skipped because a 'Maximum call stack size exceeded' message may occur. Now we use gopherjs:keep_overridden to try the original test, and skip only if the original test failed.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
One last bikeshed on this one... Now that we've settled on _gopherjs_overridden_TestOnePassCutoff(t)Do we want this? _gopherjs_original_TestOnePassCutoff(t) |
This comment has been minimized.
This comment has been minimized.
I don't feel too strongly, but seems like a good idea. |
nevkontakte
approved these changes
Jun 26, 2023
|
Reference app: jQuery TodoMVC (
#outputSize |
|
Thanks @r-l-x for creating this original PR. I'm glad to see it finally merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #798, and applied change suggested in #798 (comment), and a couple cleanups.