Fix minified variable name collision in a type generic factory function. #1237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change we always canonicalized method's type parameter names to their receiver counterparts. This was mainly necessary to avoid errors when we needed to reference method's type parameters inside a type generic factory function, e.g. when initializing method's reflection metadata.
Such implementation, however, was causing a bug when minification is enabled:
With this change, canonicalization is only done if we are outside of the method's functionContext. That way no variable name is associated with type's typeparam objects while compiling the method, and the JS variable is correctly allocated and marked as in use.
Updates #1013