Skip to content

Complete type conversion support for type parameters #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 2, 2023
Merged

Complete type conversion support for type parameters #1242

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f18e894
Implement type param conversion support for slices.
nevkontakte Oct 28, 2023
e436c07
Implement type param conversion to pointers.
nevkontakte Oct 30, 2023
772d85d
Implement type param conversion to structs and arrays.
nevkontakte Nov 1, 2023
0769076
Implement type param to map conversion.
nevkontakte Nov 1, 2023
b66fa57
reflect.DeepEquals: channels of the same underlying type can be equal.
nevkontakte Nov 1, 2023
485140a
Implement type param to chan type conversion.
nevkontakte Nov 1, 2023
1bc040e
Remove stray debug print.
nevkontakte Nov 1, 2023
f2b91ba
Implement type param to function types conversion support.
nevkontakte Nov 1, 2023
4e6c8bc
Correctly recognize type conversion expressions with multiple typepar…
nevkontakte Nov 1, 2023
267a750
Re-triage gorepo test failures associated with type conversion.
nevkontakte Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Correctly recognize type conversion expressions with multiple typepar… 
…ams.

Prior to this change expressions like `ss[T1, T2](val)` where `ss` is a
parameterized type were not recognized as type conversion expressions
due to use of the *ast.IndexListExpr node.
  • Loading branch information
@nevkontakte
nevkontakte committed Nov 1, 2023
commit 4e6c8bcb00dcad6fb00fab06fc25dd034cf1afe8
7 changes: 7 additions & 0 deletions compiler/astutil/astutil.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,13 @@ func IsTypeExpr(expr ast.Expr, info *types.Info) bool {
}
_, ok = info.Uses[ident].(*types.TypeName)
return ok
case *ast.IndexListExpr:
ident, ok := e.X.(*ast.Ident)
if !ok {
return false
}
_, ok = info.Uses[ident].(*types.TypeName)
return ok
case *ast.ParenExpr:
return IsTypeExpr(e.X, info)
default:
Expand Down
2 changes: 1 addition & 1 deletion tests/gorepo/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ var knownFails = map[string]failReason{
"typeparam/issue48453.go": {category: generics, desc: "make() doesn't support generic slice types"},
"typeparam/issue49295.go": {category: generics, desc: "len() doesn't support generic pointer to array types"},
"typeparam/issue50193.go": {category: generics, desc: "invalid print format for complex numbers"},
"typeparam/issue51303.go": {category: generics, desc: "missing support for conversion into a parameterized type"},
"typeparam/issue51303.go": {category: generics, desc: "missing support for range over type parameter"},
"typeparam/issue51522a.go": {category: generics, desc: "missing support for the comparable type constraint"},
"typeparam/issue51522b.go": {category: generics, desc: "missing support for the comparable type constraint"},
"typeparam/list.go": {category: generics, desc: "missing operator support for generic types"},
Expand Down