Add type parameter support for built-in functions. #1249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For many built-ins the behavior differs depending on their argument types. In such cases, each relevant type constructor has a method implementing the built-in for that specific type, e.g. for a slice
t
of typeT
, expressionlen(t)
will translate into something likeT.$len(t)
. In some cases, where it doesn't seem performance-critical, I changed the whole implementation of the built-in to use this mechanism, even if no type parameters are involved to reduce the amount of duplicated logic.Some functions like
append()
ordelete()
put sufficiently strict constraints on the type parameter to not require runtime dispatch. In those cases I only had to tweak the code a bit to correctly identify types.Updates #1013.