[go1.19] Known fails and build issues fix #1263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has three changes:
Fixed a problem when removing/keeping imports in the parse and augment phase. The problem comes from when a file imports something without using the blank (
_) name (e.g.import "unsafe"orimport us "unsafe") , then augmentation removes all usages of that import except for one or more directives (e.g.//go:linkname). In this case leaving the import as is will cause an "unused import" error but removing the import will result in a "directive X needs import Y" error. To solve this I made this specific case change the name of the import to be a blank import (e.g.import _ "unsafe").Chocolatey doesn't have go1.19.13 so the Windows CI fails. I changed the Chocolatey to the nearest version it defines, go1.19.9. This fixes the problems for the Windows' CI.
I updated the known fails list for fixed bugs to include new known fails for tests with generics (type parameters) and removed issues which function correctly under go1.19 without generics.