Guard generics support behind an experiment flag. #1279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for GOPHERJS_EXPERIMENT environment variable that can be used to enable experimental functionality in the compiler. Experiment flags can be easily added or removed by updating fields of the internal/experiments.Flags struct. For now, only boolean flags are supported, but it should be easy enough to extend if needed. Users need to have GOPHERJS_EXPERIMENT=generics set in their environment to enable support. Adding the flag will allow us to merge generics support into the main branch before it's fully production-ready without creating unnecessary confusion for the users.
flimzy
reviewed
Mar 24, 2024
| @@ -204,6 +212,8 @@ jobs: | |||
| darwin_smoke: | |||
| macos: | |||
| xcode: 13.4.1 # Mac OS 12.6.1, see https://circleci.com/docs/using-macos/ | |||
| environment: | |||
| GOPHERJS_EXPERIMENT: generics | |||
There was a problem hiding this comment.
Do we want to run our tests (or maybe a subset) both with and without generics support, to ensure we don't break non-generics support during this transition?
There was a problem hiding this comment.
Running all tests seems prohibitively expensive, considering that they ballooned up to 30m again. But it may be worth having a smoke test of some sort. What do you think would be a reasonable subset?
| @@ -0,0 +1,122 @@ | |||
| // Package experiments managed the list of experimental feature flags supported | |||
There was a problem hiding this comment.
Suggested change
| // Package experiments managed the list of experimental feature flags supported | |
| // Package experiments manages the list of experimental feature flags supported |
flimzy
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for GOPHERJS_EXPERIMENT environment variable that can be used to enable experimental functionality in the compiler.
Experiment flags can be easily added or removed by updating fields of the internal/experiments.Flags struct. For now, only boolean flags are supported, but it should be easy enough to extend if needed.
Users need to have GOPHERJS_EXPERIMENT=generics set in their environment to enable support. Adding the flag will allow us to merge generics support into the main branch before it's fully production-ready without creating unnecessary confusion for the users.
Updates #1013