[go1.20] Added temporary generics override for time formatting #1280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All these overrides are temporary while generics development is in progress.
A few methods in
time
use generics to allowstring
or[]byte
to be used for formatting and parsing. To make these work I copied the method that needed to be temporarily replaced, then changed the generic parameter toany
. The only complication is that one of these methods returns a generic type, meaning anything calling it has to have the value cast and thus overwritten too.This is part of #1270. After these changes (and removing
var _ = &Pointer[int]{}
fromsync/atomic/type.go:40
) runninggo1.20.14 install -v && gopherjs build -v net/http
results in: