[go1.20] Override cypto/subtle XORBytes #1284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crypto/subtle package added the
XORBytes
in go1.20. This method XOR's the content of two slices into a third. This is done using unsafe slices to cast[]byte
slices to[]uintptr
slices (done to pack registers as full as possible to reduce the number of XOR's being done) or use an architecture specific method for XOR'ing the data.I added native overrides to XOR 4 bytes at a time via uint32's if possible, otherwise fallback to one byte at a time. This method is 3 to 4 times faster than only doing one byte at a time. However when it has to fallback, it is slightly slower than simply always running one byte at a time because of the alignment and size checks it has to do.
This is part of #1270