[go1.20] Temporarily overriding generics for go1.20 #1309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevkontakte
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily overriding some more generics for go1.20 without generics while generics are still being worked on.
This also includes a work around to make CI pass the generic type check for the
atomic.Pointer[T]. Since generics are being parsed correctly, I simply stripped all the functions off ofatomic.Pointer[T]so that it can't be used but left an empty structure in it's place so that the type check at go1.20.14:src/sync/atomic/type.go:40 passes. This will help the CI for go1.20 produce much more useful errors since instead of always failing inatomic.This is part of #1270