Skip to content

[go1.20] Updating generics overrides for crypto #1312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2024

Conversation

grantnelson-wf
Copy link
Collaborator

@grantnelson-wf grantnelson-wf commented May 28, 2024

I was holding off on these changes until I could figure out what was wrong with a large part of crypto (turns out the issue was in uint and unrelated to the native overrides for crypto). Since that is now merged, here is the updates to the generics native overrides for crypto.

In go1.20 crypto the curves were broken up into nearly identical parts. Our original go1.19 overrides could be reused for most of these changes with minor rework, so that's what I did. I imported the shared override implementation each place the curve was needed.

This also includes an update to the cache removal. These are not generics related, we just can't handle the garbage collect hooks for the crypto cache, so we just make it always a cache miss.

CI will still fail for go1.20. We're missing an unrelated method (I'm working on it as part of another PR), but once that's in the build passes. Then this will remove most, but not all, of the problems in crypto. There is still a buffer overflow issue that I haven't looked into yet but felt unrelated to the curves.

This is part of #1270

@nevkontakte
Copy link
Member

Thank you!

@nevkontakte nevkontakte merged commit 2b01410 into gopherjs:go1.20 May 28, 2024
1 of 4 checks passed
@grantnelson-wf grantnelson-wf deleted the updatingCrypto branch May 29, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants