[go1.20] Fixing reflect Value.Grow #1315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5610925 to
3e287f9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
grantnelson-wf
commented
Jun 12, 2024
nevkontakte
requested changes
Jun 23, 2024
5fea1c7 to
165ce97
Compare
nevkontakte
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the
reflectmethodValue.Growthat grows a slice to a contain a minimum specified capacity. This required thegrowmethod to be updated so that it can call into JS. I split theappendmethod to create agrowSlicemethod which functions similar toreflect.growslice.CI will still fail right now because
internal/godebug.setUpdateneeds to be implemented. It is implemented in another PR. With both this and thesetUpdatechange theTestGrowtests pass.This does not fix the issue with
Value.extendSliceused byValue.Append. I'm fixing that in another PR.This is part of #1270