Another attempt to move tests from CircleCI to GitHub Actions #1317
Conversation
274c864 to
cd95cd0
Compare
|
@grantnelson-wf thanks for doing this! FYI, I'm going to unsubscribe from this issue for now to stop it flooding my inbox, but please feel free to @ me whenever you need my input 🙂 |
2df4ef2 to
317211f
Compare
|
@nevkontakte and @flimzy I've got the GHA CI working! I did leave some things out, like some of the report generation and the comparison of TodoMVC builds. I couldn't tell which reports were for CircleCI logging and which, if any, were not. I also didn't bump versions much because of things like the legacy syscall test and a problem in What else should we be doing for CI? |
|
The purpose of the diff test for the TODO MVC app is to verify that our GOPATH support doesn't regress. The same app build on GOPATH or Modules mode should produce the same output, which ensures that the GOPATH build is at least as correct as the better-tested and exercised Go Modules mode. Since upstream decided to keep supporting GOPATH fore the foreseeable future, we should continue doing so as well. |
1e70daa to
42acfc2
Compare
|
Ready for review again
I'm not sure how to get the CircleCI tests to stop running, I'm assuming that's something that you guys have access to. We could also put back circle.yml for now and run both then remove CircleCI later, or put in a jobless circle.yml file that we remove later. |
There was a problem hiding this comment.
I'm happy with the current setup, thanks @grantnelson-wf! @flimzy unless you have any other suggestions, I am happy to merge.
I thought I'd take a swing at moving from CircleCI to GHA. I'm taking some ideas and solutions from #1243.
I'm new to GHA and CircleCI so this has a lot of room for improvement. Any ideas, feedback, and help is greatly appreciated.
Note: Part of the reason I build this WIP PR is because Workiva's fork is under our enterprise plan, meaning it has different rules for actions. For example it allows different sized runners but Workiva doesn't allow 3rd party tools like golangci-lint without several additional steps. So to properly test it I have to have a PR in gopherjs/gopherjs under gopherjs's cloud plan. Additionally, I did this as a separate PR from #1243 because I don't have push permission to that branch and, therefore, needed my own branch.
This is part of #1214