Make slow stdlib tests faster. #1327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main improvement here applies to crypto/internal/edwards25519/..., which use testing/quick for fuzz-style tests. Because those tests rely heavily on 64-bit math, they are much, much slower under GopherJS than upstream. I added a hook into testing/quick that allows us to cap the number of iterations a test would be allowed to execute. Although that does technically reduce coverage, it's better than disabling the test entirely and we don't change any logic in those packages in the first place. I deleted some overlays that corresponded to the old location of the same packages, the changes in this commit serve the same purpose. I also shortened a couple of tests in image/gif and crypto/x509, for the same reasons.
|
FWIW, it looks great to me. |
flimzy
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main improvement here applies to crypto/internal/edwards25519/..., which use testing/quick for fuzz-style tests. Because those tests rely heavily on 64-bit math, they are much, much slower under GopherJS than upstream.
I added a hook into testing/quick that allows us to cap the number of iterations a test would be allowed to execute. Although that does technically reduce coverage, it's better than disabling the test entirely and we don't change any logic in those packages in the first place.
I deleted some overlays that corresponded to the old location of the same packages, the changes in this commit serve the same purpose.
I also shortened a couple of tests in image/gif and crypto/x509, for the same reasons.