Adding instance tracking to the DCE #1340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0aa1d2f to
c478887
Compare
c478887 to
525b19b
Compare
This was referenced Sep 27, 2024
flimzy
approved these changes
Oct 14, 2024
flimzy
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends dead-code elimination (DCE) to handle type arguments for instantiations of generic types. Since this change reworked how the DCE works, I added a README.md that discusses the idea and direction for these changes whilst giving help to any future extensions of the DCE.
The CI should continue to pass and I added a lot of new tests in the DCE package. We should probably at some point add some integration tests in the compiler package to ensure that the correct information is being given to the DCE, but because of how large that could be, I did not do that in this PR.
This is related to #1013 and #1270