Blocking for Function Instances #1347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flimzy
reviewed
Oct 23, 2024
flimzy
approved these changes
Oct 23, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the analysis package into an internal package
I updated the analysis info to determine blocking for instances of functions taking into account the type arguments.
I added a bunch of tests to analysis info for many of the different blocking that is being checked. I left some TODO's for things that are known not to function correctly and a TODO for a test that exemplifies an issue with sharing generic information across packages. Most of these TODO's will be fixed as part of the ongoing generics effort. The issues marked with TODO's should not cause any issues with consumers since they require generics to be an issue and generics hasn't been released yet.
This is related to #1013 and #1270