Archive serialization updates and DCE fix #1354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some serialization updates for archives to fix an issue I accidentally introduced with my DCE update (sorry 😥) . The DCE data wasn't being serialized because of how I encapsulated it and kept the fields un-exported. This meant an archive that was reloaded from memory would have no DCE info and think every Decl in it are always alive. This was discovered as I was exploring what kind of information we'd need to add to an archive for cross package generic resolution.
types.Package
andtoken.FileSet
instead of having byte arrays.types.Package
from the byte array is now done earlier and we needed to still skip that if the archive is out-of-date.This is related to #1013 and #1270