Skip to content

Fix: linkname no longer causes issues for 1.24.x and probably others #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025

Conversation

IngwiePhoenix
Copy link
Contributor

This is a dead simple PR to address #1352 by updating the deps.

Not sure if I should also bump a patch version - and if so, where? - so here is the super simple, two commits, three files and three lines PR. =)

@flimzy
Copy link
Member

flimzy commented Apr 16, 2025

I wonder if we might want to keep a fork of github.com/visualfc/goembed under the gopherjs organization for this. WDYT @nevkontakte, @grantnelson-wf ?

@IngwiePhoenix
Copy link
Contributor Author

Long-term, I'd recommend doing that - and considering how limited the use of this function is, it could possibly be integrated as a sub-package in this repo and thus "internalized" rather than vendored. Just a thought tho.

Copy link
Member

@nevkontakte nevkontakte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that adopting a fork, or simply pulling in the logic into gopherjs would be ideal in the long term. In the meantime, I've reviewed the changes in the fork and they seem okay, so we can go ahead with this PR.

@nevkontakte nevkontakte enabled auto-merge April 21, 2025 14:35
@nevkontakte nevkontakte merged commit ad87dd6 into gopherjs:master Apr 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants