Add initial support for Go 1.5. #249
Conversation
Add time.loadLocation to natives. Add runtime.Version to natives. Add pprof.StartTrace, pprof.StopTrace to natives.
|
Despite it working okay on the packages I've tested (no errors, things worked), there are quite a few failing tests in CI. They seem to be related primarily to:
|
|
Very nice! Wouldn't it be super crazy awesome if we could hook up the tracing into web developer tools that support similar tracing? Not sure if there are browser APIs for this, just typing out loud. |
Yes! I think that might fall out of scope of this PR (depending on if it's trivial to do, or needs some investigation and work), but it can be a followup enhancement. Note that GopherJS already taps into the JavaScript debugger for its implementation of |
|
Closing this PR as it has been merged onto |
These are changes I had to make to GopherJS to get it to be able to compile a few simple and medium sized Go packages, using Go version
go1.5beta1.I'm not very familiar with how natives works, and why it seems some funcs are provided while others are missing (I'd love to learn more about it), so this may not be entirely correct, but I hope it's helpful as an initial start. After making these changes, everything seemed to work great so far.
This should not be merged into
masterbranch until Go 1.5 final version is officially released. Making this PR for visibility, to run CI, and because I can't make a PR into a non-existing branch (masteris the only choice).