gopherjs serve: Fix precedence of served files. #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if there was already a {base}.js file on disk (possibly as
a result of running `gopherjs build` in the past), it would take higher
precedence than the freshly compiled {base}.js file. Fix that by
rearranging the serving precedence logic as follows:
1. {base}.js && valid Go command in folder -> compiled {base}.js
2. {base}.js.map && valid Go command in folder -> compiled {base}.js.map
3. Look in all Go workspaces (GOPATH and GOROOT)
4. index.html && valid Go command in folder -> our own stub index.html
This way, if there's an index.html file on disk, it takes higher
precedence, but not {base}.js and {base}.js.map files.
neelance
added a commit
that referenced
this pull request
Jul 15, 2015
gopherjs serve: Fix precedence of served files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if there was already a {base}.js file on disk (possibly as a result of running
gopherjs buildin the past), it would take higher precedence than the freshly compiled {base}.js file. Fix that by rearranging the serving precedence logic as follows:This way, if there's an index.html file on disk, it takes higher precedence, but not {base}.js and {base}.js.map files.
Needed for gopherjs/gopherjs.github.io#25.