WIP: Refactor attempt to move t === timePkg.Time check out. #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor based on suggestion at #287 (comment). Panic on null or undefined values instead of Date, no support for *time.Time. Remove unneeded declaration. The same variable is already declared in parent scope.
81cc5d8 to
fc96db6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to follow suggestion in #287 (comment).
Not quite sure it's an improvement at this time, but maybe it just needs more work?
No handling of
nullorundefinedvalues instead ofDate. Also no support for*time.Timeat this time.Feel free to make changes as you see fit here. This is a PR into PR #288 (branch
fix-287).