Skip to content

Set NODE_PATH environment variable #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Oct 19, 2015

This is a proposed partial fix for #303.

This PR does not address the potential security issues, or do anything to handle node dependencies of Go dependencies. But those issues can be addressed in separate PRs if this one is deemed appropriate for merge in the mean time.

@neelance
Copy link
Member

As mentioned in #303, the temporary files should be created in the current working directory to make node behave as expected. In this case we would not need this change, right?

@flimzy
Copy link
Member Author

flimzy commented Oct 19, 2015

#334 accomplishes the same thing with a different means, so closing this PR.

@flimzy flimzy closed this Oct 19, 2015
@flimzy flimzy deleted the nodepath branch September 5, 2016 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants