compiler/natives/syscall: Don't import bytes package. #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a047cf to
402d303
Compare
The real syscall package doesn't import bytes. This keeps the order in which stdlib packages must be built in for GopherJS consistent with the real standard library. Helps #388.
402d303 to
ce68d34
Compare
|
LGTM |
dmitshur
added a commit
that referenced
this pull request
Jun 26, 2016
The real time package doesn't import strings package. This keeps the import graph of augmented time package consistent with the real standard library. Source: https://godoc.org/time?import-graph This is a change analogous to #453.
dmitshur
added a commit
that referenced
this pull request
Jun 26, 2016
The real time package doesn't import strings package. This keeps the import graph of augmented time package consistent with the real standard library. Source: https://godoc.org/time?import-graph This is a change analogous to #453.
dmitshur
added a commit
that referenced
this pull request
Jun 26, 2016
The real time package doesn't import strings package. This keeps the import graph of augmented time package consistent with the real standard library. Source: https://godoc.org/time?import-graph This is a change analogous to #453.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The real syscall package doesn't import bytes. This keeps the order in which stdlib packages must be built in for GopherJS consistent with the real standard library.
Source: https://godoc.org/syscall?import-graph
Helps #388.