compiler/natives/src/time: Don't import strings package. #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88d7a4e to
e3e3a44
Compare
|
LGTM |
|
It's a really good improvement. |
The real time package doesn't import strings package. This keeps the import graph of augmented time package consistent with the real standard library. Source: https://godoc.org/time?import-graph This is a change analogous to #453.
e3e3a44 to
ad1c074
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The real time package doesn't import strings package. This keeps the
import graph of augmented time package consistent with the real
standard library.
Source: https://godoc.org/time?import-graph
This is a change analogous to #453.