Add support for Go 1.7. #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 of 5 failures is os/exec usage, which is definitely not supported. Another bug is with runtime.Caller not printing the right output. I'm not sure if this is supported, since "runtime" package support is said to be "partial" in the compatibility table. /cc @neelance In any case, CI right now doesn't have IO module installed, so there's no way it could pass. Maybe later. The other 3 bugs are valid issues that have been found after 1.6 was released. Marked them with validButDealWithAfterGo17SinceNew category, and marked as "known failures" for now. We can have a TODO to resolve them and turn them into real issues after GopherJS support for Go 1.7 is out. /cc @neelance
|
Great, as of f8e7e29, the |
|
Quick check with go1.7 and it appears to be working for me! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR to add support for Go 1.7, which has been released recently.
It's still WIP. Most tests are passing thanks to @neelance's work so far, but there are a few that are not.
Known issues:
archive/tarTestReadertest is panicking because of Slice capacity not preserved when taken address of and converted to another type. #496.Resolves #475 when merged.