Skip to content

README: Document that using vendored GopherJS is currently not supported. #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2016
Merged

README: Document that using vendored GopherJS is currently not supported. #538

merged 1 commit into from
Oct 18, 2016

Conversation

dmitshur
Copy link
Member

@dmitshur dmitshur commented Oct 18, 2016 •
edited
Loading

GopherJS itself supports vendoring, but vendoring it into your project is currently not supported. Issue #415 tracks the progress on fixing that.

Helps #415.
Updates #537.

/cc @jraedisch and @myitcv FYI.

@dmitshur
README: Document that using vendored GopherJS is currently not suppor…
5e8a800 
…ted.

GopherJS itself supports vendoring, but vendoring _it_ into your project
is currently not supported. Issue #415 tracks the progress on fixing that.

Helps #415.
Updates #537.
@dmitshur dmitshur merged commit 64c7aad into master Oct 18, 2016
@dmitshur dmitshur deleted the README-document-vendoring-limitation branch October 18, 2016 16:51
dmitshur added a commit to gopherjs/gopherjs.github.io that referenced this pull request Oct 19, 2016
@dmitshur
Regenerate website.
c3cac82 
go generate

Includes change from gopherjs/gopherjs#538.
@dmitshur dmitshur mentioned this pull request Jan 12, 2017
Closed
dmitshur added a commit that referenced this pull request Jan 12, 2017
@dmitshur
compiler/typesutil: Detect vendored js package and exit.
42e6459 
This follows #538.

Vendoring github.com/gopherjs/gopherjs/js package is not supported, and can cause
hard to understand runtime errors. Better catch it earlier and print a clear error message.

Helps #569.
@dmitshur dmitshur mentioned this pull request Jan 12, 2017
Merged
dmitshur added a commit that referenced this pull request Jan 13, 2017
@dmitshur
build: Detect vendored js package and return error. (#572)
0203db2 
This follows #538.

Vendoring github.com/gopherjs/gopherjs/js package is not supported, and can cause
hard to understand runtime errors. Better catch it earlier and print a clear error message.

Helps #569.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neelance neelance neelance approved these changes

Assignees

@neelance neelance

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmitshur @neelance