Skip to content

Make runnable Examples work #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 27, 2017
Merged

Make runnable Examples work #590

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a21effa
Import the official example.go
flimzy Feb 17, 2017
3b6e16e
Use a temp file for stdout redirection instead of a pipe
flimzy Feb 17, 2017
061f8e7
Execute examples in CI
flimzy Feb 17, 2017
f919c8f
Move ioutil functions inline to avoid extra import.
flimzy Feb 17, 2017
e4ec7a2
Don't import filepath
flimzy Feb 17, 2017
c44e315
Disable two Examples not supported by GopherJS
flimzy Feb 21, 2017
f27bcb9
Check io.Copy errors
flimzy Feb 21, 2017
01ef481
Always remove the temp file, even in case of error
flimzy Feb 21, 2017
8431197
compiler/natives/src/testing: Fix build errors.
dmitshur Feb 21, 2017
35de0ce
compiler/natives/src: Fix package name; gofmt.
dmitshur Feb 21, 2017
3a1ff31
compiler/natives/src: Print expected output for disabled examples.
dmitshur Feb 21, 2017
3173746
compiler/natives/src/testing: Update comment to match behavior.
dmitshur Feb 26, 2017
26efd8b
compiler/natives: Regenerate.
dmitshur Feb 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Always remove the temp file, even in case of error
  • Loading branch information
@flimzy @dmitshur
flimzy authored and dmitshur committed Feb 27, 2017
commit 01ef481aea2c69d54096b4669ee92bbd38607ceb
8 changes: 4 additions & 4 deletions compiler/natives/src/testing/example.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ func runExample(eg InternalExample) (ok bool) {
// Close pipe, restore stdout, get output.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, we've changed the code to use file rather than pipe, but the comment still says pipe.

I can fix it.

w.Close()
os.Stdout = stdout
out, e := readFile(w.Name())
if e != nil {
fmt.Fprintf(os.Stderr, "testing: reading stdout file: %v\n", e)
out, readFileErr := readFile(w.Name())
_ = os.Remove(w.Name())
if readFileErr != nil {
fmt.Fprintf(os.Stderr, "testing: reading stdout file: %v\n", readFileErr)
os.Exit(1)
}
_ = os.Remove(w.Name())

var fail string
err := recover()
Expand Down