Skip to content

Go 1.9 support (version bump to GopherJS 1.9-1). #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 50 commits into from
Aug 27, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
15a2eea
Target Go 1.9 Beta 1, update version to GopherJS 1.9-wip.
dmitshur Jun 23, 2017
72e0b64
compiler/natives/src/runtime: Keep throw accessible for Go code to use.
dmitshur Jun 23, 2017
0927aef
compiler/natives/src/runtime: Add noop implementation of CallersFrames.
dmitshur Jun 23, 2017
0cbbd7f
compiler/natives/src/sync: Update SemacquireMutex, Semrelease signatu…
dmitshur Jun 23, 2017
c5eec2e
compiler/natives/src/time: Update now signature for monotonic time.
dmitshur Jun 23, 2017
7b4a889
compiler/natives/src/reflect: Update signatures.
dmitshur Jun 23, 2017
9212049
compiler/natives: Regenerate.
dmitshur Jun 23, 2017
981eddd
compiler/natives/src/os/signal: Create no-op implementation.
dmitshur Jun 24, 2017
b946d67
compiler/natives/src/testing: Use a basic but working callerName.
dmitshur Jun 24, 2017
956dce4
compiler/natives/src/internal/poll: Create no-op I/O poller implement…
dmitshur Jun 24, 2017
38f3fb7
compiler/natives: Regenerate.
dmitshur Jun 24, 2017
9ffc87e
WIP: nosync: Implement sync.Map.
dmitshur Jun 24, 2017
640751f
compiler: Set anonymous bit for struct fields correctly.
dmitshur Jun 24, 2017
44d151d
compiler/natives/src/reflect: Set pkgPath for new implements checks.
dmitshur Jun 24, 2017
15ab3c0
compiler: Fix panic due to type aliases.
dmitshur Jun 24, 2017
c8a99bb
compiler/natives/src/math/big: Remove bitLen, override Word.
dmitshur Jun 24, 2017
67e7e39
compiler/natives: Regenerate.
dmitshur Jun 24, 2017
b9c0354
CI: Don't minify when running tests.
dmitshur Jun 24, 2017
dd65c22
compiler/natives/src/math: Implement missing functions.
dmitshur Jun 24, 2017
c7683d9
compiler/natives/src/net: Implement missing private helpers.
dmitshur Jun 24, 2017
fbf0086
compiler/natives/src/encoding/gob: Disable broken test case.
dmitshur Jun 24, 2017
41a477d
compiler/natives: Regenerate.
dmitshur Jun 24, 2017
d8a12c0
compiler/natives/src/sync: Add missing private helper.
dmitshur Jun 25, 2017
63f374f
compiler/natives/src/time: Add initial support for monotonic clock.
dmitshur Jun 25, 2017
576b4d7
compiler/natives: Regenerate.
dmitshur Jun 25, 2017
dcc17c5
tests: Classify new Go 1.9 tests.
dmitshur Jun 25, 2017
e39dba4
compiler/natives/src/crypto/x509: Update package and tests for Go 1.9.
dmitshur Jun 26, 2017
ce54604
CI: Use --verbose flag with gopherjs test command.
dmitshur Jun 26, 2017
ffae93c
compiler/natives: Regenerate.
dmitshur Jun 26, 2017
8b8c47a
CI: Update to Go 1.9 Beta 2.
dmitshur Jun 26, 2017
cc16cdc
CI: Update to Go 1.9 RC 1.
dmitshur Jul 25, 2017
b0dc25e
compiler/natives/src/internal/poll: Add pollDesc.pollable method.
dmitshur Jul 25, 2017
99fd1ff
compiler/natives: Regenerate.
dmitshur Jul 25, 2017
49ee3df
compiler/natives/src/math/big: Use math_big_pure_go build tag.
dmitshur Jul 25, 2017
355d52e
compiler/natives/src/sync: Implement newly referenced test helpers.
dmitshur Jul 25, 2017
052972b
compiler/natives: Add missing // +build js build constraint.
dmitshur Jul 25, 2017
cc693ed
compiler/natives: Regenerate.
dmitshur Jul 25, 2017
208c5eb
Address remaining code review comments.
dmitshur Jul 25, 2017
f6209e7
compiler/natives: Regenerate.
dmitshur Jul 25, 2017
6759a49
CI: Fix check for forgotten // +build js constraints in natives.
dmitshur Jul 25, 2017
00a3767
build: Don't use cgo for "os/user", "crypto/x509".
dmitshur Jul 27, 2017
ba3e852
CI: Update to Go 1.9 RC 2.
dmitshur Aug 8, 2017
07ee55b
CI: Update to Go 1.9 final release.
dmitshur Aug 25, 2017
7e6a73a
Add math/bits to supported package list.
dmitshur Aug 25, 2017
91dd575
compiler: Restore previous behavior of skipping unsafe import.
dmitshur Aug 25, 2017
62cb4ed
CI: Prefer --minify flag for all tests.
dmitshur Aug 25, 2017
be67827
compiler: Replace old importer with x/tools/go/gcimporter15.
dmitshur Aug 26, 2017
61693e9
compiler: Simplify type alias handling.
dmitshur Aug 26, 2017
34e2783
compiler: Skip type aliases in all named type considerations.
dmitshur Aug 26, 2017
fe63fb1
compiler: Bump GopherJS version to 1.9-1.
dmitshur Aug 26, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
compiler/natives/src/crypto/x509: Update package and tests for Go 1.9.
Skip new Go 1.9 Linux-only test TestEnvVars that depends on system
roots, which GopherJS doesn't support. This is quite okay, as they're
not supported on Windows either:

	func SystemCertPool() (*CertPool, error) {
		if runtime.GOOS == "windows" {
			// Issue 16736, 18609:
			return nil, errors.New("crypto/x509: system root pool is not available on Windows")
		}

		return loadSystemRoots()
	}

Return non-nil error in loadSystemRoots so that x509.SystemCertPool
correctly reports a failure. As a result, need to skip
TestSystemCertPool now too.

There's no need to override execSecurityRoots, because nothing needs or
calls it (the things that do are overridden or skipped).
  • Loading branch information
dmitshur committed Aug 25, 2017
commit e39dba420d95600d3cc2732a66f8c2eea0bcc8f6
9 changes: 2 additions & 7 deletions compiler/natives/src/crypto/x509/x509.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,8 @@

package x509

import "os"
import "errors"

func loadSystemRoots() (*CertPool, error) {
// no system roots
return NewCertPool(), nil
}

func execSecurityRoots() (*CertPool, error) {
return nil, os.ErrNotExist
return nil, errors.New("crypto/x509: system root pool is not available in GopherJS")
}
8 changes: 8 additions & 0 deletions compiler/natives/src/crypto/x509/x509_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,18 @@ package x509

import "testing"

func TestSystemCertPool(t *testing.T) {
t.Skip("no system roots")
}

func TestSystemRoots(t *testing.T) {
t.Skip("no system roots")
}

func TestEnvVars(t *testing.T) {
t.Skip("no system roots")
}

func TestSystemVerify(t *testing.T) {
t.Skip("no system")
}
Expand Down