Fix "sync: inconsistent mutex state" panic #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in runtime_SemacquireMutex() gopherjs#736
dmitshur
approved these changes
Jan 9, 2018
There was a problem hiding this comment.
Thanks a lot for this fix @canning-duck.
I've tested your changes on the Go 1.10 branch and they work well. It fixes TestMutexFairness and the test program you posted in #736.
It's passing all tests on Go 1.9 too (via CI).
LGTM.
compiler/natives/src/sync/sync.go
Outdated
| @@ -5,22 +5,32 @@ package sync | |||
| import "github.com/gopherjs/gopherjs/js" | |||
|
|
|||
| var semWaiters = make(map[*uint32][]chan bool) | |||
| var semAwoken = make(map[*uint32]uint32) | |||
There was a problem hiding this comment.
It would be nice to document what this map tracks.
go generate ./...
|
Thank you again @canning-duck for investigating and fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lifoparameter inruntime_SemacquireMutex(not strictly required but improve the mutex fairness).TestMutexFairness is now passing. Tested with Go 1.9 (
gopherjs test -v sync).#736