Skip to content

README: Clarify {{base}} in gopherjs serve. #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 18, 2018
Merged

Conversation

dmitshur
Copy link
Member

It might be confusing, so just use the example values and mention that the
.js file name comes from the directory name. Hopefully, this is more clear.

Updates #408.

/cc @baram204 Do you think this is easier to understand?

It might be confusing, so just use the example values and mention that the
.js file name comes from the directory name. Hopefully, this is more clear.

Updates #408.
"base directory" is a pretty general term, and hopefully it's understandable
to everyone from the context.
Copy link
Member

@myitcv myitcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - nice clarification

@dmitshur dmitshur merged commit 178c176 into master Jan 18, 2018
@dmitshur dmitshur deleted the README-serve-base branch January 18, 2018 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants