Skip to content

[WIP] ci: parallelise the running of gopherjs tests #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

myitcv
Copy link
Member

@myitcv myitcv commented Apr 18, 2018

DO NOT REVIEW

DO NOT MERGE

Based on #797 - this will need a rebase once #797 is merged.

See the diff this PR introduces on top of #797 here

Currently we run the gopherjs tests in sequence; this is limited to a
single CPU core because we ultimately run the tests via Node. We can
improve on this by concurrently running gopherjs test per package.

myitcv.io/cmd/concsh helps do does just that:

https://github.com/myitcv/x/blob/master/cmd/concsh/README.md

Also implemented a fix discussed in a previous issue/PR to make our list
of package exclusions explicit, via std_test_pkg_exclusions

@myitcv myitcv force-pushed the parallelize_gopherjs_test_run branch 7 times, most recently from 0606312 to 6ac1f4a Compare April 18, 2018 15:46
@myitcv myitcv force-pushed the parallelize_gopherjs_test_run branch from 6ac1f4a to 20a0780 Compare April 18, 2018 21:28
Currently we run the gopherjs tests in sequence; this is limited to a
single CPU core because we ultimately run the tests via Node. We can
improve on this by concurrently running gopherjs test per package.

Also implemented a fix discussed in a previous issue/PR to make our list
of package exclusions explicit, via std_test_pkg_exclusions
@myitcv myitcv force-pushed the parallelize_gopherjs_test_run branch from 20a0780 to 4dd3bfa Compare April 18, 2018 21:31
@myitcv myitcv changed the title ci: parallelise the running of gopherjs tests [WIP] ci: parallelise the running of gopherjs tests Apr 18, 2018
@myitcv
Copy link
Member Author

myitcv commented Apr 22, 2018

I'm going to abandon this change because I'm losing too much time to fighting CircleCI!

For anyone who wants to parallelise local tests:

go get -u myitcv.io/cmd/concsh
cat <(go list github.com/gopherjs/gopherjs/tests/...) <(go list std | grep -v -x -f .std_test_pkg_exclusions) | sed -e "s/^/gopherjs test -m /" | $(go list -f "{{.Target}}" myitcv.io/cmd/concsh) --conc $(nproc --all)

will use all your cores to run the gopherjs test tests in parallel.

@myitcv myitcv closed this Apr 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant