Added viewport support and defered execution on gopherjs serve #860
Conversation
tool.go
Outdated
| <script defer src="`+base+`.js"></script> | ||
| </head> | ||
| <body></body> | ||
| </html>`)), nil |
There was a problem hiding this comment.
No tabs before <body> and </html>?
There was a problem hiding this comment.
Should I push a new commit with perfect indentation?
Or should I leave it for you or other contributors?
There was a problem hiding this comment.
Please add a new commit, and wait for another contributor's review.
|
I think it is ok to merge this, and revert this if we find problems. |
|
I tried to add Then I opened #571 to discuss the situation and look for a good solution that didn't compromise on the no-flash goal. It seems this PR is a duplicate of #570, except it also adds a viewport and whitespace. Sorry I didn't see it earlier @hajimehoshi. |
|
Ah I understood. Sorry I didn't wait for your reviews. Should we revert this? |
Yes, I think so. The problems with this approach are already known, so it's not necessary to wait to discover them. It's hard to find a good default index.html that will work for everyone needs, so I think it's fair to supply a minimal one. Projects can always provide their own custom index.html if they need to override some behavior.
No problem, I'm glad you're taking action and following up on it! |
#860)" This reverts commit bf5fc7d. Reason: Discussion at #570 (comment)
#860)" (#866) This reverts commit bf5fc7d. Reason: Discussion at #570 (comment)
viewport
Added
<meta name="viewport" content="initial-scale=1">for responsive web development environment with gopherjs viagopherjs servecommand!Deferred execution
Added
deferto execute the script as soon as the page load finished!