Go 1.11.1 support (version bump to GopherJS 1.11-2). #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.11.1 has been released recently. It includes some changes to the reflect package, including: - golang/go@a2f1c8e - golang/go@3afa9df - golang/go@58c9bd9 The second commit makes some changes to internal reflect code that makes GopherJS reflect overrides no longer compatible, causing the package to no longer build: $ gopherjs build reflect /usr/local/go/src/reflect/value.go:673:60: cannot use t (variable of type *rtype) as *funcType value in argument to funcLayout /usr/local/go/src/reflect/value.go:336:21: cannot use methodReceiver(op, v, int(v.flag) >> flagMethodShift) (value of type *rtype) as *funcType value in assignment Specifically, the type of return value t of function methodReceiver was changed from *rtype to *funcType in commit golang/go@3afa9df. This change updates the native reflect override for methodReceiver function and Value.call method accordingly. Regenerate natives with: go generate ./compiler/natives Use Go 1.11.1 in CI. Bump GopherJS version to GopherJS 1.11-2. Fixes #862.
|
LGTM. It's not a goal for GopherJS to still also support Go 1.11(.0) is it? (Doesn't seem worthwhile if it's difficult.) |
It would be a goal, but I didn't see any easy way of making it happen (there are only build tags for But now that I think about it, it wouldn't be too hard to special-case it in |
Create a custom go1.11.1 release tag (to be applied whenever Go version is 1.11.1 or greater) and use it to select the appropriate overrides for the reflect package for Go 1.11.1 and Go 1.11(.0). This way, GopherJS 1.11-2 will function with Go 1.11.1 and Go 1.11(.0) versions, rather than only with Go 1.11.1. Regenerate ./compiler/natives.
dmitshur
added a commit
that referenced
this pull request
Aug 12, 2019
GopherJS 1.12 is out by now, so it's safe to remove this code that was added to deal with differences between Go 1.11.0 and Go 1.11.1. Do so by moving the actively used code from reflect_go1111.go back into reflect.go as it was before PR #865, and delete reflect_go111.go. There should not be any change in behavior. Regenerate ./compiler/natives. Updates #862.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.11.1 has been released recently. It includes some changes to the
reflectpackage, including:The second commit makes some changes to internal reflect code that
makes GopherJS
reflectoverrides no longer compatible, causing thepackage to no longer build:
Specifically, the type of return value
tof functionmethodReceiverwas changed from
*rtypeto*funcTypein commit golang/go@3afa9df.This change updates the native
reflectoverride formethodReceiverfunction and
Value.callmethod accordingly.Regenerate natives with:
Use Go 1.11.1 in CI.
Bump GopherJS version to GopherJS 1.11-2.
Fixes #862. /cc @bradfitz @katiehockman