Support Go 1.13 and Go 1.14 both #964

visualfc · 2020-02-08T15:14:32Z

Build on Go 1.13 / Go 1.14 and one build support working on Go 1.12 Go 1.13 Go 1.14 three version.

cd goproj/src
git clone https://github.com/visualfc/gopherjs github.com/gopherjs/gopherjs
cd github.com/gopherjs/gopherjs
git checkout go1.13-dev
go install -v

This version build and install on Go 1.13 or Go 1.14. And one build support working on Go 1.12 1.13 1.14 three version and dynamic select internal compiler/natives/src.
This version build and install on Go 1.12 and working on Go 1.12 only.
if change install go version, please use -a flags to force rebuild packages.
gopherjs build -a -v or gopherjs test -a -v

add internal/reflectlite for Go 1.13 Go 1.14
update syscall/js API for Go 1.13 Go 1.14 changes
support Go Module, build go project check go.mod ( use go env)
add -a (--force) flags to force rebuild packages
check installed go version for build ReleaseTags, support working Go 1.12 Go 1.13 Go 1.14 three version

…t: update for Go1.13

…I changes

…nge go version request rebuild packages

…o 1.12 1.13 1.14

dmitshur · 2020-02-08T19:03:09Z

CI is failing because the circle.yml file in this PR doesn't include the fix for issue #937 that was applied in commit 1852f3a. @visualfc Can you include it?

visualfc · 2020-02-09T02:46:20Z

CI is failing because the circle.yml file in this PR doesn't include the fix for issue #937 that was applied in commit 1852f3a. @visualfc Can you include it?

update, but tests failed for CI.

dmitshur · 2020-02-09T03:29:43Z

It's failing because the diff -u <(echo -n) <(go list ./compiler/natives/src/...) step is reporting a non-zero diff. You should add a // +build js constraint to the newly added files in that directory.

nevkontakte · 2020-09-17T22:07:33Z

Any news? I have multiple reasons to prefer GopherJS over Go/WASM, but at some point being able to use an up to date version will outweigh the advantages of GopherJS and the headache of migration :-(

pjebs · 2020-09-17T22:19:13Z

If someone hard forks, I'm happy to migrate over

inliquid · 2020-09-18T11:59:31Z

@nevkontakte this is from Slack:

flimzy · 2020-09-18T12:06:08Z

:( Sounds like a fork is in order, then.

neelance · 2020-09-18T12:25:32Z

Yes, feel free to create a fork. If it is well maintained for a while, then we can endorse it or maybe even consider a merge at some point. But first Dmitri and I would like to see that the maintenance situation turns out better than what we are currently able to provide. :)

pjebs · 2020-09-18T12:38:24Z

what should it be called? jsgopher or gojs?

flimzy · 2020-09-18T12:51:10Z

what should it be called? jsgopher or gojs?

I suggest we either open a new issue, and/or open a slack conversation about this, and other housekeeping details (which organization, who has commit access, etc, etc) so we don't clutter this PR, and so we have a canonical place to point people for posterity. WDYT?

nevkontakte · 2020-09-18T18:21:19Z

@inliquid thanks for bringing the clarity.

@flimzy I suppose #894 is an appropriate place for this kind of discussion. Let's continue it there, shall we?

visualfc · 2020-10-13T23:42:03Z

support work on Go1.15 https://github.com/visualfc/gopherjs/tree/go1.15-dev

pjebs · 2020-10-13T23:50:40Z

@visualfc Can you merge it to master in your fork so I can use it? I think it's time to adopt yours as the "official" gopherjs.
If you want, you can create an organization. Perhaps called: "gojs". And then transfer the repo under that organization.

Thanks for the amazing work.

visualfc · 2020-10-15T03:59:21Z

https://github.com/goplusjs/gopherjs for supported Go 1.12~1.15

go get -u github.com/goplusjs/gopherjs

all test on macOS

pjebs · 2020-10-15T06:12:35Z

Does it pass all the go unit tests?

visualfc · 2020-10-30T06:28:05Z

Does it pass all the go unit tests?

https://github.com/goplusjs/gopherjs
test pass on macOS Go1.12~Go1.15

flimzy · 2021-01-31T10:33:44Z

@neelance thanks for the offer. The amount of spare time I have is also limited, but I do indeed have a few projects in production that rely on GopherJS. If there's no better volunteer available, I'm happy to join :)

@nevkontakte, are you still interested in helping to maintain this project? If so, would you mind adding your name to the document mentioned here? #964 (comment) And if not, that's of course perfectly understandable.

nevkontakte · 2021-01-31T12:41:56Z

@flimzy I already have (the second entry) 😃

flimzy · 2021-01-31T13:02:23Z

@flimzy I already have (the second entry)

Ha! Sorry I didn't make the connection. And happy you've expressed interest :)

flimzy · 2021-02-02T16:01:16Z

@visualfc I should have pinged you, too. I know you're making pretty strong headway on your own fork now, so may not be interested in GopherJS any longer, but I want to make sure you have a chance to voice your interest, if you want. #964 (comment)

I'm going to try to schedule a call with those interested in helping, to discuss next steps, and if you are interested, of course I'd love to involve you.

visualfc · 2021-02-02T23:47:51Z

@visualfc I should have pinged you, too. I know you're making pretty strong headway on your own fork now, so may not be interested in GopherJS any longer, but I want to make sure you have a chance to voice your interest, if you want. #964 (comment)

I'm going to try to schedule a call with those interested in helping, to discuss next steps, and if you are interested, of course I'd love to involve you.

I hope GopherJS can support more go versions. my fork and experiment can support go1.16rc1.

flimzy · 2021-02-03T08:21:36Z

I hope GopherJS can support more go versions. my fork and experiment can support go1.16rc1.

Does this mean you're not interested in participating in the GopherJS planning call?

visualfc · 2021-02-03T09:07:18Z

I hope GopherJS can support more go versions. my fork and experiment can support go1.16rc1.

Does this mean you're not interested in participating in the GopherJS planning call?

If gopherjs has plans to review PR, I will submit PR again.

flimzy · 2021-02-03T09:08:19Z

If gopherjs has plans to review PR, I will submit PR again.

That's clear. Thank you for your response. Hopefully we can start reviewing PRs again soon!

visualfc · 2021-02-06T02:43:50Z

https://github.com/goplusjs/gopherjs/releases/tag/v1.1.8

support go1.16rc1 go:embed

pjebs · 2021-02-06T02:52:45Z

I want to make my https://github.com/rocketlaunchr/react package compatible with gopherjs and your package @visualfc . Do you know how I can do it?

visualfc · 2021-02-06T04:55:41Z

I want to make my https://github.com/rocketlaunchr/react package compatible with gopherjs and your package @visualfc . Do you know how I can do it?

project keep stay import "github.com/gopherjs/gopherjs/js" or use "syscall/js" for compatible wasm
go get -u github.com/goplusjs/gopherjs for install gopherjs

visualfc · 2021-02-20T09:26:48Z

https://github.com/goplusjs/gopherjs now support Go 1.12~1.16

Go1.12~1.15 test actions on macOS, Go1.16 test action on Ubuntu.

pjebs · 2021-02-20T10:20:48Z

@visualfc I made a PR in your repo.

flimzy · 2021-04-09T11:52:56Z

Now that #1015 has been merged, GopherJS is up to date with the latest upstream Go, so I'm going to close this PR.

visualfc added 16 commits January 25, 2020 21:00

compiler/natives/src/internal/reflectlite: add for Go 1.13 internal API

6d6d029

compiler/natives/src/syscall/js: update for Go 1.13 internal API changes

7c96e2e

compiler/natives/src/internal/reflectlite,compiler/natives/src/reflec…

752b670

…t: update for Go1.13

update circle.yml go1.13.6

587694b

compiler/natives/src/syscall/js: update js panic error for Go 1.13 AP…

8a7356a

…I changes

add github.com/visualfc/fastmod for build project use go.mod dep

cfd313f

add go.mod

3e8fc9f

build: add internal/goversion for check install go ReleaseTags

e230287

build: add -f --force rebuild package flags. (if update --tags or cha…

05591e7

…nge go version request rebuild packages

compiler/natives/src/sync: support go1.12 go1.13 both

ea61ac0

compiler/natives/math: fix build for Go 1.14

ad4d281

compiler/natives/src/syscall/js: support Go 1.12 1.13 1.14 three

c6d6d64

compiler/natives/src/reflect: support Go 1.12 1.13 both

254d3d2

compiler/natives/fs: fix importPathToDir for Go1.14

afb4460

vertion_check: update build for Go 1.13/1.14 and support go=>js for G…

08185fa

…o 1.12 1.13 1.14

fix vendor test only Go 1.12

07467f7

visualfc requested review from dmitshur and hajimehoshi February 8, 2020 15:16

visualfc added 2 commits February 9, 2020 10:20

update fs_vfsdata.go

f1852a6

fix circle.yml CI failing

2452510

visualfc force-pushed the go1.13-dev branch from 916b08b to 2452510 Compare February 9, 2020 02:23

visualfc added 2 commits February 9, 2020 10:39

update circle.yml go1.12.9

638a258

version_check: support Go 1.12 1.13 both

f40b392

visualfc added 4 commits February 9, 2020 17:01

compiler/natives/src/internal/reflectlite: fix utils.go +build js

e115225

fix pkg.Goroot not load mod

8153f60

update circle.yml go1.13.6

9a3412f

update .std_test_pkg_exclusions

edca086

emidoots mentioned this pull request Aug 15, 2020

Deprecate and remove GopherJS support from Vecty hexops/vecty#264

Closed

neelance mentioned this pull request Jan 31, 2021

Health and future of the GopherJS open source project #894

Closed

flimzy closed this Apr 9, 2021

Support Go 1.13 and Go 1.14 both #964

Support Go 1.13 and Go 1.14 both #964

Uh oh!

Conversation

visualfc commented Feb 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dmitshur commented Feb 8, 2020

Uh oh!

visualfc commented Feb 9, 2020

Uh oh!

dmitshur commented Feb 9, 2020

Uh oh!

nevkontakte commented Sep 17, 2020

Uh oh!

pjebs commented Sep 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

inliquid commented Sep 18, 2020

Uh oh!

flimzy commented Sep 18, 2020

Uh oh!

neelance commented Sep 18, 2020

Uh oh!

pjebs commented Sep 18, 2020

Uh oh!

flimzy commented Sep 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nevkontakte commented Sep 18, 2020

Uh oh!

visualfc commented Oct 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pjebs commented Oct 13, 2020

Uh oh!

visualfc commented Oct 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pjebs commented Oct 15, 2020

Uh oh!

visualfc commented Oct 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flimzy commented Jan 31, 2021

Uh oh!

nevkontakte commented Jan 31, 2021

Uh oh!

flimzy commented Jan 31, 2021

Uh oh!

flimzy commented Feb 2, 2021

Uh oh!

visualfc commented Feb 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flimzy commented Feb 3, 2021

Uh oh!

visualfc commented Feb 3, 2021

Uh oh!

flimzy commented Feb 3, 2021

Uh oh!

visualfc commented Feb 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pjebs commented Feb 6, 2021

Uh oh!

visualfc commented Feb 6, 2021

Uh oh!

visualfc commented Feb 20, 2021

Uh oh!

pjebs commented Feb 20, 2021

Uh oh!

flimzy commented Apr 9, 2021

Uh oh!

Uh oh!

visualfc commented Feb 8, 2020 •

edited

Loading

pjebs commented Sep 17, 2020 •

edited

Loading

flimzy commented Sep 18, 2020 •

edited

Loading

visualfc commented Oct 13, 2020 •

edited

Loading

visualfc commented Oct 15, 2020 •

edited

Loading

visualfc commented Oct 30, 2020 •

edited

Loading

visualfc commented Feb 2, 2021 •

edited

Loading

visualfc commented Feb 6, 2021 •

edited

Loading