Support testing package with Go 1.16 and re-enable most of its tests.
#995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flimzy
approved these changes
Mar 12, 2021
There were two major issues with the package:
- os.RemoveAll() implementation on linux was using Fstatat syscall,
which doesn't work with the node-syscall extension (see gopherjs#993).
- runtime.Callers() is not implemented by GopherJS, which causes
testing package to report source code locations according to the JS
output file rather than the original Go code. I had to skip a bunch
of tests because of that, but at least most other tests can be
tracked now.
e44c38d to
92299b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two major issues with the package:
which doesn't work with the node-syscall extension (see node-syscall doesn't support struct-pointer arguments #993).
testing package to report source code locations according to the JS
output file rather than the original Go code. I had to skip a bunch
of tests because of that, but at least most other tests can be
tracked now.
Updates #989.